Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ProductionKind from parser runtime #721

Merged
merged 1 commit into from
Dec 21, 2023
Merged

remove ProductionKind from parser runtime #721

merged 1 commit into from
Dec 21, 2023

Conversation

OmarTawfik
Copy link
Contributor

remaining from #699

@OmarTawfik OmarTawfik requested a review from a team as a code owner December 21, 2023 11:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 80e89f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik mentioned this pull request Dec 21, 2023
Merged
Xanewok
Xanewok approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I missed that! I'd love to get rid of at least some of the template machinery to catch stuff like this...

@Xanewok Xanewok added this pull request to the merge queue Dec 21, 2023
Merged via the queue into main with commit be5932e Dec 21, 2023
2 checks passed
@Xanewok Xanewok deleted the remove-production-kind branch December 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @Xanewok