Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve keywords more correctly in DSL v1 #644

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Nov 7, 2023

The DSL v1 and the codegen assumes that keyword "enablement" is the same as the keyword being reserved, i.e. not usable in the identifier position. This patch uses that to correctly reserve keywords and parse correctly more code.

While this still unfortunately does not handle the known cases where the atom can be accepted as identifier or a keyword, i.e. emit in 0.4.22, this is strictly more correct and this will help by minimizing the final diff once we switch to DSL v2, since the new definition already uses these correct enabled/reserved version ranges.

Ref #638

@Xanewok Xanewok requested a review from a team as a code owner November 7, 2023 15:19
Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: 650d805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Xanewok Xanewok added this pull request to the merge queue Nov 8, 2023
Merged via the queue into NomicFoundation:main with commit cb57044 Nov 8, 2023
1 check passed
@Xanewok Xanewok deleted the fix-reserve-keywords-in-dslv1 branch November 8, 2023 08:46
@Xanewok Xanewok mentioned this pull request Nov 13, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants