Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ebnf writer bugs #1214

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix ebnf writer bugs #1214

merged 1 commit into from
Jan 9, 2025

Conversation

OmarTawfik
Copy link
Contributor

  • Scanner::Not was serialized to a sequence, not a choice.
  • render negative lookaheads, as it was hidden.
  • change Expression::Range to primary expression.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0f96e8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik
fix ebnf writer bugs
0f96e8c 
- `Scanner::Not` was serialized to a sequence, not a choice.
- render negative lookaheads, as it was hidden.
- change `Expression::Range` to primary expression.
@OmarTawfik OmarTawfik marked this pull request as ready for review January 5, 2025 17:36
@OmarTawfik OmarTawfik requested review from a team as code owners January 5, 2025 17:36
@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 9, 2025
Merged via the queue into NomicFoundation:main with commit a640e59 Jan 9, 2025
1 check passed
@OmarTawfik OmarTawfik deleted the fix-ebnf-bugs branch January 9, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjoerussell mjoerussell mjoerussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @mjoerussell