Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test definiens cursors and verify that all identifiers are bound #1200

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

ggiraldez
Copy link
Contributor

@ggiraldez ggiraldez commented Dec 20, 2024

Closes #1191
Closes #1199

  • Add output of definiens cursors in all bindings snapshots
  • Check all Identifier and YulIdentifier nodes are bound to a reference or definition (except those under ExperimentalFeature) in snapshots
  • Fix missing binding for catch clauses: the identifiers there can only be Error or Panic, but they are still parsed as identifiers (maybe it's better to add them as keywords?). Also added them as error definitions in built-ins.
  • Relax modifier definition rules to bind the name identifier even if failing to parse the body.

Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: a6403cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggiraldez ggiraldez marked this pull request as ready for review December 20, 2024 23:34
@ggiraldez ggiraldez requested review from a team as code owners December 20, 2024 23:34
@ggiraldez ggiraldez enabled auto-merge December 23, 2024 16:31
@ggiraldez ggiraldez added this pull request to the merge queue Dec 23, 2024
Merged via the queue into NomicFoundation:main with commit be24831 Dec 23, 2024
1 check passed
@ggiraldez ggiraldez deleted the test-definiens branch December 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test coverage for undetected bindings add Definition::get_definiens_cursor() to test snapshots
2 participants