Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding rules for inline assembly #1087

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Binding rules for inline assembly #1087

merged 8 commits into from
Aug 23, 2024

Conversation

ggiraldez
Copy link
Contributor

Adds binding rules to support inline Yul assembly

@ggiraldez ggiraldez requested a review from a team as a code owner August 21, 2024 20:03
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e7fbd81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggiraldez ggiraldez mentioned this pull request Aug 21, 2024
Closed
33 tasks
OmarTawfik
OmarTawfik reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nit suggestions. Otherwise, LGTM!

@ggiraldez ggiraldez requested a review from OmarTawfik August 22, 2024 21:16
OmarTawfik
OmarTawfik approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only left a few nit suggestions.

@OmarTawfik OmarTawfik added this pull request to the merge queue Aug 23, 2024
Merged via the queue into NomicFoundation:main with commit 8c3c13a Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik OmarTawfik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggiraldez @OmarTawfik