Remove remaining mentions of #638 in the code #1021
Conversation
|
| @@ -1,8 +1,4 @@ | |||
| //! Definitions of the [`GrammarElement`]s and the grammar itself ([`Grammar`]). | |||
| // TODO(#638): This is a leftover module from the original DSLv1 implementation. | |||
There was a problem hiding this comment.
We agreed that we want to keep the grammar around as a structured representation of the language definition for the purposes of parser generator, so this stays. Everything is co-located as well, so it's a lot easier to edit and adapt the code if needed.
| @@ -10,7 +10,6 @@ pub enum TriviaParser { | |||
| Choice { parsers: Vec<TriviaParser> }, | |||
|
|
|||
| Optional { parser: Box<TriviaParser> }, | |||
| // TODO(#638): Remove this, once we adapt the DSL v1 codegen model to the new v2 definition. | |||
There was a problem hiding this comment.
Anything that will touch the trivia as part of the #1020 will probably have to adapt this but doesn't strictly have to, so there's no point in keeping this TODO as it's optional and tracked elsewhere.
Moreover, we need to keep using OneOrMore for the current valid definition of leading_trivia and ZeroOrMore is unused but might be as part of #1020; I'm happy to remove it as part of this PR per YAGNI.
|
Thanks a lot for the reviews @OmarTawfik and for bearing with me over all of these issues/PRs along the way 😅 🙏 |
0a2b0d4
Closes #638
The trivia item from #638 is now separately tracked in #1020.