refactor: Prefer explicit Clone over From<&Borrowed> for Owned impls (

#964)

Extracted from #963 in case we want to land this separately.

crates/codegen/runtime/cargo/src/runtime/napi_interface/cst.rs

@@ -61,7 +61,7 @@ impl RuleNode {
         catch_unwind
     )]
     pub fn text_len(&self) -> TextIndex {
-        (&self.0.text_len).into()
+        self.0.text_len.into()
     }
 
     #[napi(ts_return_type = "Array<cst.Node>", catch_unwind)]
@@ -79,7 +79,7 @@ impl RuleNode {
         #[napi(ts_arg_type = "text_index.TextIndex")] text_offset: TextIndex,
     ) -> Cursor {
         RustNode::Rule(Rc::clone(&self.0))
-            .cursor_with_offset((&text_offset).into())
+            .cursor_with_offset(text_offset.into())
             .into()
     }
 
@@ -149,7 +149,7 @@ impl TokenNode {
     )]
     pub fn text_len(&self) -> TextIndex {
         let text_len: RustTextIndex = (&self.0.text).into();
-        (&text_len).into()
+        text_len.into()
     }
 
     #[napi(getter, catch_unwind)]
@@ -171,7 +171,7 @@ impl TokenNode {
         #[napi(ts_arg_type = "text_index.TextIndex")] text_offset: TextIndex,
     ) -> Cursor {
         RustNode::Token(Rc::clone(&self.0))
-            .cursor_with_offset((&text_offset).into())
+            .cursor_with_offset(text_offset.into())
             .into()
     }
 }

crates/codegen/runtime/cargo/src/runtime/napi_interface/cursor.rs

@@ -63,12 +63,12 @@ impl Cursor {
 
     #[napi(getter, ts_return_type = "text_index.TextIndex", catch_unwind)]
     pub fn text_offset(&self) -> TextIndex {
-        (&self.0.text_offset()).into()
+        self.0.text_offset().into()
     }
 
     #[napi(getter, ts_return_type = "text_index.TextRange", catch_unwind)]
     pub fn text_range(&self) -> TextRange {
-        (&self.0.text_range()).into()
+        self.0.text_range().into()
     }
 
     #[allow(clippy::cast_possible_truncation)] // Cursor depth can't reasonably be larger than u32

crates/codegen/runtime/cargo/src/runtime/napi_interface/parse_error.rs

@@ -20,7 +20,7 @@ impl From<RustParseError> for ParseError {
 impl ParseError {
     #[napi(getter, ts_return_type = "text_index.TextRange", catch_unwind)]
     pub fn text_range(&self) -> TextRange {
-        self.0.text_range().into()
+        self.0.text_range().clone().into()
     }
 
     #[napi(catch_unwind)]

crates/codegen/runtime/cargo/src/runtime/napi_interface/text_index.rs

@@ -10,8 +10,8 @@ pub struct TextIndex {
     pub char: u32,
 }
 
-impl From<&RustTextIndex> for TextIndex {
-    fn from(value: &RustTextIndex) -> Self {
+impl From<RustTextIndex> for TextIndex {
+    fn from(value: RustTextIndex) -> Self {
         // We only support 32-byte indices on TS side.
         #[allow(clippy::cast_possible_truncation)]
         Self {
@@ -22,8 +22,8 @@ impl From<&RustTextIndex> for TextIndex {
     }
 }
 
-impl From<&TextIndex> for RustTextIndex {
-    fn from(value: &TextIndex) -> Self {
+impl From<TextIndex> for RustTextIndex {
+    fn from(value: TextIndex) -> Self {
         Self {
             utf8: value.utf8 as usize,
             utf16: value.utf16 as usize,
@@ -39,11 +39,11 @@ pub struct TextRange {
     pub end: TextIndex,
 }
 
-impl From<&RustTextRange> for TextRange {
-    fn from(value: &RustTextRange) -> Self {
+impl From<RustTextRange> for TextRange {
+    fn from(value: RustTextRange) -> Self {
         Self {
-            start: (&value.start).into(),
-            end: (&value.end).into(),
+            start: value.start.into(),
+            end: value.end.into(),
         }
     }
 }

crates/metaslang/cst/src/text_index.rs

@@ -37,26 +37,12 @@ impl Display for TextIndex {
     }
 }
 
-impl From<&str> for TextIndex {
-    fn from(s: &str) -> Self {
+impl<T: AsRef<str>> From<T> for TextIndex {
+    fn from(s: T) -> Self {
         let mut utf8 = 0;
         let mut utf16 = 0;
         let mut char = 0;
-        for c in s.chars() {
-            utf8 += c.len_utf8();
-            utf16 += c.len_utf16();
-            char += 1;
-        }
-        Self { utf8, utf16, char }
-    }
-}
-
-impl From<&String> for TextIndex {
-    fn from(s: &String) -> Self {
-        let mut utf8 = 0;
-        let mut utf16 = 0;
-        let mut char = 0;
-        for c in s.chars() {
+        for c in s.as_ref().chars() {
             utf8 += c.len_utf8();
             utf16 += c.len_utf16();
             char += 1;