fix: nonce-syncing check of mempool transactions (PR 8) #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
force-pushed
the
fix/rerun-nonce-check
branch
2 times, most recently
from
8b59f63 to
41e103f
Compare
kanej
commented
Oct 3, 2023
packages/core/src/internal/execution/nonce-management/get-nonce-sync-messages.ts
Show resolved
Hide resolved
kanej
force-pushed
the
fix/rerun-nonce-check
branch
2 times, most recently
from
277b374 to
49fa3ca
Compare
kanej
changed the title
kanej
changed the title
kanej
force-pushed
the
fix/additional-nonces-checks
branch
from
27c9b30 to
9d8ee09
Compare
kanej
force-pushed
the
fix/rerun-nonce-check
branch
from
49fa3ca to
349ac76
Compare
alcuadrado
approved these changes
Oct 4, 2023
kanej
force-pushed
the
fix/additional-nonces-checks
branch
2 times, most recently
from
77a16e9 to
60bd877
Compare
There was a wrong check on whether the transactions against the last network interaction are still in the mempool. If at least one transaction is in the mempool we don't do the further checks that assume the transacion with that nonce has been either dropped or replaced by the user. I have added a test for the failing case of rerun at the command line. Fixes #506.
kanej
force-pushed
the
fix/rerun-nonce-check
branch
from
349ac76 to
65b1338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a wrong check on whether the transactions against the last network interaction are still in the mempool. If at least one transaction is in the mempool we don't do the further checks that assume the transaction with that nonce has been either dropped or replaced by the user.
I have added a test for the failing case of rerun at the command line.
Fixes #506.