fix/additional-nonces-checks (PR 7) #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
changed the title
kanej
commented
Oct 2, 2023
packages/core/src/internal/execution/nonce-management/get-nonce-sync-messages.ts
Show resolved
Hide resolved
kanej
commented
Oct 2, 2023
packages/core/src/internal/execution/nonce-management/get-nonce-sync-messages.ts
Show resolved
Hide resolved
kanej
commented
Oct 2, 2023
packages/core/src/internal/execution/nonce-management/get-nonce-sync-messages.ts
Show resolved
Hide resolved
kanej
commented
Oct 2, 2023
kanej
force-pushed
the
fix/additional-nonces-checks
branch
from
080fb4b to
27c9b30
Compare
kanej
force-pushed
the
feat/status-command
branch
from
dfbd3d8 to
0d427d0
Compare
kanej
force-pushed
the
fix/additional-nonces-checks
branch
from
27c9b30 to
9d8ee09
Compare
alcuadrado
approved these changes
Oct 4, 2023
kanej
force-pushed
the
feat/status-command
branch
from
0d427d0 to
8d96286
Compare
kanej
force-pushed
the
fix/additional-nonces-checks
branch
from
9d8ee09 to
77a16e9
Compare
The senders that will be used if the module executes, taking into account usage of default sender when `from` is undefined. Resolves #411
Add some basic tests around the nonce synce conditions.
Pull up helper methods. The goal is to focus on the things that affect the outcome. Not a big fan of DRY in tests, but the state manipulation was getting too cumbersome.
kanej
force-pushed
the
fix/additional-nonces-checks
branch
from
77a16e9 to
60bd877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the future senders from the module when syncing nonces for checks.
The senders for all futures without exStates that will be used if the module executes, are now added to the syncing taking into account usage of default sender when
fromis undefined.Resolves #411