Show missing futures warnings in execution UI

packages/core/src/internal/deployer.ts

@@ -174,7 +174,9 @@ export class Deployer {
     }
 
     if (reconciliationResult.missingExecutedFutures.length > 0) {
-      // TODO: indicate to UI that warnings should be shown
+      this._emitReconciliationWarningsEvent(
+        reconciliationResult.missingExecutedFutures
+      );
     }
 
     const batches = Batcher.batch(ignitionModule, deploymentState);
@@ -275,6 +277,17 @@ export class Deployer {
     });
   }
 
+  private _emitReconciliationWarningsEvent(warnings: string[]): void {
+    if (this._executionEventListener === undefined) {
+      return;
+    }
+
+    this._executionEventListener.reconciliationWarnings({
+      type: ExecutionEventType.RECONCILIATION_WARNINGS,
+      warnings,
+    });
+  }
+
   private _emitDeploymentBatchEvent(batches: string[][]): void {
     if (this._executionEventListener === undefined) {
       return;

packages/core/src/types/execution-events.ts

@@ -30,6 +30,7 @@ export type ExecutionEvent =
   | OnchainInteractionTimeoutEvent
   | BatchInitializeEvent
   | DeploymentStartEvent
+  | ReconciliationWarningsEvent
   | BeginNextBatchEvent
   | SetModuleIdEvent;
 
@@ -61,6 +62,7 @@ export enum ExecutionEventType {
   ONCHAIN_INTERACTION_TIMEOUT = "ONCHAIN_INTERACTION_TIMEOUT",
   BATCH_INITIALIZE = "BATCH_INITIALIZE",
   DEPLOYMENT_START = "DEPLOYMENT_START",
+  RECONCILIATION_WARNINGS = "RECONCILIATION_WARNINGS",
   BEGIN_NEXT_BATCH = "BEGIN_NEXT_BATCH",
   DEPLOYMENT_COMPLETE = "DEPLOYMENT_COMPLETE",
   SET_MODULE_ID = "SET_MODULE_ID",
@@ -116,6 +118,16 @@ export interface DeploymentCompleteEvent {
   result: DeploymentResult<string, IgnitionModuleResult<string>>;
 }
 
+/**
+ * An event indicating that a deployment has reconciliation warnings.
+ *
+ * @beta
+ */
+export interface ReconciliationWarningsEvent {
+  type: ExecutionEventType.RECONCILIATION_WARNINGS;
+  warnings: string[];
+}
+
 /**
  * An event indicating a future that deploys a contract
  * or library has started execution.
@@ -434,6 +446,7 @@ export interface ExecutionEventTypeMap {
   [ExecutionEventType.DEPLOYMENT_START]: DeploymentStartEvent;
   [ExecutionEventType.BEGIN_NEXT_BATCH]: BeginNextBatchEvent;
   [ExecutionEventType.DEPLOYMENT_COMPLETE]: DeploymentCompleteEvent;
+  [ExecutionEventType.RECONCILIATION_WARNINGS]: ReconciliationWarningsEvent;
   [ExecutionEventType.SET_MODULE_ID]: SetModuleIdEvent;
 }
 

packages/hardhat-plugin/src/ui/UiEventHandler.tsx

@@ -22,6 +22,7 @@ import {
   OnchainInteractionReplacedByUserEvent,
   OnchainInteractionTimeoutEvent,
   ReadEventArgExecutionStateInitializeEvent,
+  ReconciliationWarningsEvent,
   RunStartEvent,
   SendDataExecutionStateCompleteEvent,
   SendDataExecutionStateInitializeEvent,
@@ -68,6 +69,7 @@ export class UiEventHandler implements ExecutionEventListener {
     moduleName: null,
     batches: [],
     result: null,
+    warnings: [],
   };
 
   constructor(private _deploymentParams: DeploymentParameters = {}) {}
@@ -333,6 +335,13 @@ export class UiEventHandler implements ExecutionEventListener {
     };
   }
 
+  public reconciliationWarnings(event: ReconciliationWarningsEvent): void {
+    this.state = {
+      ...this.state,
+      warnings: [...this.state.warnings, ...event.warnings],
+    };
+  }
+
   public setModuleId(event: SetModuleIdEvent): void {
     this.state = {
       ...this.state,

packages/hardhat-plugin/src/ui/VerboseEventHandler.ts

@@ -17,6 +17,7 @@ import {
   OnchainInteractionReplacedByUserEvent,
   OnchainInteractionTimeoutEvent,
   ReadEventArgExecutionStateInitializeEvent,
+  ReconciliationWarningsEvent,
   RunStartEvent,
   SendDataExecutionStateCompleteEvent,
   SendDataExecutionStateInitializeEvent,
@@ -251,6 +252,14 @@ export class VerboseEventHandler implements ExecutionEventListener {
     console.log(`Deployment complete`);
   }
 
+  public reconciliationWarnings(event: ReconciliationWarningsEvent): void {
+    console.log(
+      `Deployment produced reconciliation warnings:\n${event.warnings.join(
+        "  -"
+      )}`
+    );
+  }
+
   public setModuleId(event: SetModuleIdEvent): void {
     console.log(`Starting validation for module: ${event.moduleName}`);
   }

packages/hardhat-plugin/src/ui/components/execution/ExecutionPanel.tsx

@@ -7,6 +7,7 @@ import { UiState } from "../../types";
 import { BatchExecution } from "./BatchExecution";
 import { FinalStatus } from "./FinalStatus";
 import { SummarySection } from "./SummarySection";
+import { Warnings } from "./Warnings";
 import { viewEverythingExecutedAlready } from "./views";
 
 export const ExecutionPanel = ({
@@ -19,6 +20,7 @@ export const ExecutionPanel = ({
   if (viewEverythingExecutedAlready(state)) {
     return (
       <Box flexDirection="column">
+        {state.warnings.length > 0 && <Warnings state={state} />}
         <FinalStatus state={state} />
       </Box>
     );
@@ -27,6 +29,7 @@ export const ExecutionPanel = ({
   return (
     <Box flexDirection="column">
       <SummarySection state={state} deployParams={deployParams} />
+      {state.warnings.length > 0 && <Warnings state={state} />}
       <BatchExecution state={state} />
       <FinalStatus state={state} />
     </Box>

packages/hardhat-plugin/src/ui/components/execution/Warnings.tsx

@@ -0,0 +1,23 @@
+import { Box, Newline, Text } from "ink";
+
+import { UiState } from "../../types";
+
+export const Warnings = ({ state: { warnings } }: { state: UiState }) => {
+  return (
+    <>
+      <Box
+        paddingBottom={1}
+        borderStyle="single"
+        flexDirection="column"
+        borderColor="yellowBright"
+      >
+        <Text bold>
+          Warning, deployment missing previously executed futures:
+        </Text>
+        <Newline />
+
+        {...warnings.map((warning) => <Text> - {warning}</Text>)}
+      </Box>
+    </>
+  );
+};

packages/hardhat-plugin/src/ui/types.ts

@@ -61,6 +61,7 @@ export interface UiState {
   moduleName: string | null;
   batches: UiBatches;
   result: DeploymentResult<string, IgnitionModuleResult<string>> | null;
+  warnings: string[];
 }
 
 export interface AddressMap {