Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployed addresses only show top level module #480

Closed
kanej opened this issue Sep 20, 2023 · 0 comments · Fixed by #482
Closed

deployed addresses only show top level module #480

kanej opened this issue Sep 20, 2023 · 0 comments · Fixed by #482
Assignees
@kanej
Labels
status:ready This issue is ready to be worked on type:bug Something isn't working
Milestone
Beta v0.11.0

Comments

@kanej
Copy link
Member

kanej commented Sep 20, 2023

Take the SubmodulesExample from the ignition examples repo:

image

We are not listing all the deployed contracts in the results section. Only the contracts deployed by the top level module.
@kanej kanej added type:bug Something isn't working status:ready This issue is ready to be worked on and removed status:triaging labels Sep 20, 2023
@kanej kanej moved this to Todo in Hardhat Ignition Sep 20, 2023
@kanej kanej added this to the Beta v0.5.0 milestone Sep 20, 2023
@kanej kanej moved this from Todo to In Progress in Hardhat Ignition Sep 20, 2023
@kanej kanej self-assigned this Sep 20, 2023
kanej added a commit that referenced this issue Sep 20, 2023
@kanej
fix: display all deployed contracts
31edccd 
The result was constrained to only those contracts returned by the
module. It now returns all contracts and contractAts that have been
deployed in this run and previous runs.

The `ignition-helper` now takes the responsibility of resolving the
modules results to contracts (and only the result contracts).

Note the types have not been altered.

Resolves #480.
@kanej kanej mentioned this issue Sep 20, 2023
Merged
@kanej kanej moved this from In Progress to In Review in Hardhat Ignition Sep 20, 2023
kanej added a commit that referenced this issue Sep 29, 2023
@kanej
fix: display all deployed contracts
422c821 
The result was constrained to only those contracts returned by the
module. It now returns all contracts and contractAts that have been
deployed in this run and previous runs.

The `ignition-helper` now takes the responsibility of resolving the
modules results to contracts (and only the result contracts).

Note the types have not been altered.

Resolves #480.
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Oct 2, 2023
@kanej kanej mentioned this issue Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanej kanej

Labels
status:ready This issue is ready to be worked on type:bug Something isn't working
Projects
Hardhat Ignition
Archived in project
Milestone
Beta v0.11.0
Development

Successfully merging a pull request may close this issue.

fix: display all deployed contracts (PR 3) NomicFoundation/hardhat-ignition
1 participant
@kanej