fix: display all deployed contracts (PR 3) #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unsure of this change. Currently deploy returns a deployment result. That deployment result type encodes the return results of the module passed in. That misled us, I think the deployed contracts should include the contracts, librarys and contractsAts that are deployed in the module and its submodules. This PR expands the returned results to include those contracts in submodules. However, I have not changed the type. I think there are two approaches we can consider:
|
kanej
changed the title
The result was constrained to only those contracts returned by the module. It now returns all contracts and contractAts that have been deployed in this run and previous runs. The `ignition-helper` now takes the responsibility of resolving the modules results to contracts (and only the result contracts). Note the types have not been altered. Resolves #480.
kanej
force-pushed
the
fix/display-all-deployed
branch
from
31edccd to
422c821
Compare
kanej
changed the base branch from
development
to
fix/allow-reconciliation-of-undefined-from
The success result no longer includes the type of the current modules results. The deploy result includes contracts from previous runs, hence the type is too restrictive.
alcuadrado
approved these changes
Oct 2, 2023
Base automatically changed from
fix/allow-reconciliation-of-undefined-from
to
development
October 2, 2023 19:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result was constrained to only those contracts returned by the module. It now returns all contracts and contractAts that have been deployed in this run and previous runs.
The
ignition-helpernow takes the responsibility of resolving the modules results to contracts (and only the result contracts).Note the types have not been altered.
Resolves #480.