Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report config error on invalid artifact #704

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: report config error on invalid artifact #704

merged 1 commit into from
Oct 22, 2024

Conversation

agostbiro
Copy link
Member

Make sure the config error callback is called with an error if an invalid artifact is provided. Partially fixes #700

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 2861562

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agostbiro agostbiro requested a review from Wodann October 21, 2024 17:02
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 17:02 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 17:02 — with GitHub Actions Inactive
@agostbiro agostbiro requested a review from galargh October 21, 2024 17:02
@agostbiro agostbiro self-assigned this Oct 21, 2024
@agostbiro agostbiro added the no changeset needed This PR doesn't require a changeset label Oct 21, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 19:00 — with GitHub Actions Inactive
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 19:01 — with GitHub Actions Inactive
@agostbiro agostbiro had a problem deploying to github-action-benchmark October 21, 2024 19:01 — with GitHub Actions Failure
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 21, 2024 20:36 — with GitHub Actions Inactive
galargh
galargh approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@agostbiro agostbiro merged commit 7aaf746 into feat/solidity-tests Oct 22, 2024
41 checks passed
@agostbiro agostbiro deleted the fix/config-error-on-invalid-artifact branch October 22, 2024 09:26
@agostbiro agostbiro mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wodann Wodann Wodann approved these changes

@galargh galargh galargh approved these changes

Assignees

@agostbiro agostbiro

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agostbiro @galargh @Wodann