Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove total difficulty from block #695

Closed
wants to merge 2 commits into from

Conversation

agostbiro
Copy link
Member

Removes totalDifficulty from eth_getBlockByNumber and eth_getBlockByHash responses following the change to the Ethereum execution API schema which Geth has implemented and it's causing problems for Hardhat in fork mode when EDR doesn't receive the totalDifficulty field from Geth nodes.

Relevant Hardhat issues:

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 3bc7ea0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agostbiro agostbiro self-assigned this Oct 14, 2024
@agostbiro agostbiro temporarily deployed to github-action-benchmark October 14, 2024 14:02 — with GitHub Actions Inactive
@agostbiro agostbiro requested a review from alcuadrado October 14, 2024 14:02
@agostbiro
Copy link
Member Author

Superseded by #697

@agostbiro agostbiro closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant