Skip to content

Commit

Permalink
ci: remove synthetic benchmarks (#460)
Browse files Browse the repository at this point in the history
* ci: remove synthetic benchmarks

Remove synthetic benchmarks as they've been superseded by scenario benchmarks.

* chore: remove unused crate (#461)
  • Loading branch information
agostbiro authored May 22, 2024
1 parent af8053f commit cffc411
Show file tree
Hide file tree
Showing 13 changed files with 3 additions and 944 deletions.
4 changes: 2 additions & 2 deletions .cargo-husky/hooks/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

if [ -z "${ALCHEMY_URL}" ] || [ -z "${INFURA_URL}" ]; then
echo WARNING: skipping remote tests because the ALCHEMY_URL and INFURA_URL environment variables are not defined. Local test results may differ from those in CI.
ALL_FEATURES="--features tracing,bench-once,serde,std"
ALL_FEATURES="--features tracing,serde,std"
else
ALL_FEATURES=--all-features
fi
Expand All @@ -14,7 +14,7 @@ fi
set -xe

# Setting RUSTFLAGS env for clippy makes it not include custom rules
RUSTFLAGS=-Dwarnings cargo check --workspace --all-targets --profile bench ${ALL_FEATURES}
RUSTFLAGS=-Dwarnings cargo check --workspace --all-targets ${ALL_FEATURES}
cargo clippy --all --all-targets ${ALL_FEATURES} -- -D warnings
cargo +nightly fmt --all -- --check
cargo test --doc --workspace ${ALL_FEATURES}
Expand Down
81 changes: 0 additions & 81 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions book/src/01_getting_started/03_test.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@ cargo t --all-features
To only run local tests, execute:

```bash
cargo t --features bench-once,serde,std,tracing
cargo t --features serde,std,tracing
```

The `bench-once` feature flag is used to ensure that benchmarks only run one iteration, to avoid taking too long.

## Hardhat

To validate that the port of Hardhat Node to EDR did not break any functionality, we implemented the EDR integration alongside the existing TypeScript code.
Expand Down
24 changes: 0 additions & 24 deletions crates/edr_evm/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[lib]
bench = false

[package]
name = "edr_evm"
version = "0.3.5"
Expand Down Expand Up @@ -39,27 +36,6 @@ serial_test = "2.0.0"
tempfile = "3.7.1"

[features]
bench-once = [] # limits the benchmark variants to one
test-remote = []
test-utils = []
tracing = ["dep:tracing", "edr_eth/tracing"]

[[bench]]
name = "database_commit"
path = "benches/state/database_commit.rs"
harness = false

[[bench]]
name = "state_clone"
path = "benches/state/state_clone.rs"
harness = false

[[bench]]
name = "state_debug"
path = "benches/state/state_debug.rs"
harness = false

[[bench]]
name = "state_ref"
path = "benches/state/state_ref.rs"
harness = false
106 changes: 0 additions & 106 deletions crates/edr_evm/benches/state/database_commit.rs

This file was deleted.

This file was deleted.

19 changes: 0 additions & 19 deletions crates/edr_evm/benches/state/state_clone.rs

This file was deleted.

Loading

0 comments on commit cffc411

Please sign in to comment.