Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean translation #93

Merged
merged 2 commits into from
May 15, 2024
Merged

Korean translation #93

merged 2 commits into from
May 15, 2024

Conversation

NavyStack
Copy link
Contributor

First and foremost, I wish to express my sincere appreciation for the development of such an outstanding plugin.

In my role as the coordinator for NodeBB's Korean and Japanese translations, I have strived to maintain consistency in wording with the primary translation project.


At present, numerous default plugins of NodeBB come pre-installed.
However, it appears that this applies not only to administrators but also to end-users.
Therefore, it would be advantageous to enable the management of built-in plugin translations on Transifex as well.

While I currently utilize NodeBB in production, there are instances where certain strings or plugins remain untranslatable, often exposing my users, who are not proficient in English, to such content.
Hence, I would kindly request your consideration on this matter.

Below, I have outlined several queries regarding the plugin, along with suggestions for enhancement:


  1. Some applications use a space character when presenting a 6-digit number. For instance, 123456 may appear as 123 456 when copied to the clipboard.
    Given the increasing prevalence of users utilizing this feature via a browser extension plugin, I believe enhancing the user experience by disregarding space characters and accepting numbers solely would be beneficial.

  2. There are instances where 2FA (Two-Factor Authentication) needs to be input more than once due to specific circumstances.
    For instance, upon pasting it into a browser or application, users are prompted to re-enter their username and password, even if the values are accurate. This could be due to either rapid typing or previous input.

    Personally, I circumvent this inconvenience by pressing and holding the CTRL key while performing CTRL + V.
    (But... sometimes I face Username and Password form page.)
    However, this workaround may prove inconvenient for the average user.

    While acknowledging the inherent trade-off between security and convenience, I believe there is room for improvement in this regard, particularly concerning 2FA.

  3. Occasionally, upon entering my username, password, and 2FA code, I find myself logged in as a non-member pop-up. This issue warrants attention for resolution.

Your attention to these matters would be greatly appreciated, and I am confident that addressing these concerns would significantly enhance the usability and functionality of the plugin.


I am currently using NodeBB in a production environment. Hence, updating without translations results in English displaying as is, akin to a bleeding edge situation. I kindly request measures to improve this.

You can verify my commit timestamps, which reflect my working pace. There's ample time to pre-translate adequately for any additions. Your cooperation in presenting translation sentences prior to adding new strings would be greatly appreciated.

Thanks for your support.

@julianlam
Copy link
Member

I apologize for not responding promptly, I was not aware this issue was opened.

I will look into this more thoroughly tomorrow.

@julianlam julianlam merged commit 0911dc0 into NodeBB:master May 15, 2024
@julianlam
Copy link
Member

Thanks for your comments, and I apologize for taking so long to address them!

I am not certain where issues 2 and 3 come from, but if you are able to find a set of reproducible steps, that would be helpful for me to debug.

@julianlam
Copy link
Member

The first issue I will open separately: #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants