Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for atomic ops on NoBrainer::Array (and any other Array subclasses) #292

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodeMonkeySteve
Copy link
Contributor

No description provided.

@zedtux
Copy link
Collaborator

zedtux commented Apr 21, 2023

Can you please give a short explanation for this change? Also do you think adding a test would make sense?

@CodeMonkeySteve
Copy link
Contributor Author

(finally getting around to addressing this, sorry it took so long)

Currently the atomic_ops only work with ::Array, this fix makes it also work with NoBrainer::Array, NoBrainer::TypedArray, and any other Array subclasses.

It really should have at least a basic test, so I added one for TypedArray (the arrays shared example group made that easy).

CodeMonkeySteve added a commit to CodeMonkeySteve/nobrainer that referenced this pull request Nov 28, 2024
@CodeMonkeySteve
Copy link
Contributor Author

@zedtux looks like CI is broken, all the jobs are failing with project name must not be empty, and I have no idea how to fix that. Please take a look at it when you get a chance. Merci!

@zedtux
Copy link
Collaborator

zedtux commented Dec 2, 2024

Yeah, this is a docker compose error, I will look at it. Thank you for the update!

@zedtux
Copy link
Collaborator

zedtux commented Dec 12, 2024

I made a fix on master but there's an RSpec test failing which is weird since it was passing before, so I have to check it and fix it.

CodeMonkeySteve added a commit to CodeMonkeySteve/nobrainer that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants