Validate CODEOWNERS #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
force-pushed
the
validate-codeowners
branch
3 times, most recently
from
50d3496 to
bf702b6
Compare
Also make CI run for all pull requests, not just ones to the main branch. This allows testing pull_request_target changes in this repo.
infinisil
force-pushed
the
validate-codeowners
branch
from
bf702b6 to
93bd4e6
Compare
infinisil
force-pushed
the
validate-codeowners
branch
5 times, most recently
from
6f023bf to
569ec01
Compare
infinisil
force-pushed
the
validate-codeowners
branch
2 times, most recently
from
5640fc3 to
0454b67
Compare
To satisfy the new check requiring all files to have a code owner
infinisil
force-pushed
the
validate-codeowners
branch
from
0454b67 to
9028d17
Compare
|
Now also added @zimbatm as codeowner to all files that didn't have one before. |
zimbatm
approved these changes
Apr 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts validating the CODEOWNERS file using https://github.com/mszostok/codeowners-validator and, because that project doesn't support it yet, a custom script to make sure that everybody has write access.
To make this work, I introduced the
OWNERS_VALIDATOR_GITHUB_SECRETsecret to contain a read-only personal access token of mine for now (expires in 30 days). This is needed because it's not possible to query for who has write access without that. In the future we should switch to a GitHub App instead.Because we need to switch to
pull_request_targetto trigger CI, I had to test this in a separate PR, but it works:Furthermore, the check to make sure everybody has write access is also run in the regular monthly review, which I can confirm to work correctly: