libsForQt5.qtkeychain: add libsecret support #60327
Conversation
|
I am not sure if setting @Ma27 do you think you could try it without the wrapper? |
|
Okay, I tried without it and it did not work. Not sure why they are linking. (Edit: they seem to use types from the library, though I am not sure why would that require linking.) Keeping the |
There was a problem hiding this comment.
Unfortunately I'm not sure either, when I took the maintainership for nextcloud-client, a wrapper was already used for libgnome-keyring back then.
libsecret is in its closure.
I'm probably missing something right now, but doesn't libsecret need to be in nextcloud-clients's rpath to be found?
qtkeychain uses pkg-config to detect whether libsecret is available, otherwise it just builds a stub object file. We need libsecret support to allow nextcloud-client storing passwords on Freedesktop platforms. I also fixed the Darwin dependencies not being used with Qt5, even though the build did not complain.
Yeah, being in |
jtojnar
force-pushed
the
qtkeychain-libsecret
branch
from
15acf97 to
48316ae
Compare
|
Ahh, I see! Thanks a lot for tracking this problem down! |
|
Should we drop qt4 while at it? |
|
Tomahawk still depends on it. We can drop both in a separate PR. |
|
Thanks! According to the reporter, |
|
Tomahawk still depends on it. We can drop both in a separate PR.
…On Mon, 29 Apr, 2019 at 8:17 AM, Peter Hoeg ***@***.***> wrote:
Should we drop qt4 while at it?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/NixOS/nixpkgs","title":"NixOS/nixpkgs","subtitle":"GitHub
repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open
in
***@***.***
in #60327: Should we drop qt4 while at it?"}],"action":{"name":"View
Pull
Request","url":"#60327 (comment)"}}}
[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage",
"potentialAction": { ***@***.***": "ViewAction", "target":
"#60327 (comment)",
"url":
"#60327 (comment)",
"name": "View Pull Request" }, "description": "View this Pull Request
on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub",
"url": "https://github.com" } } ]
|
![https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open](https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open){kind=link}
Motivation for this change
qtkeychain uses pkg-config to detect whether libsecret is available,
otherwise it just builds a stub object file.
We need libsecret support to allow nextcloud-client storing passwords
on Freedesktop platforms.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)