Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-client: fix qt error at startup #54484

Merged
merged 1 commit into from
Jan 25, 2019
Merged

nextcloud-client: fix qt error at startup #54484

merged 1 commit into from
Jan 25, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 22, 2019 •
edited
Loading

Motivation for this change

The QT_PLUGIN_PATH couldn't find the needed xcb plugin.

See also #51044

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nextcloud-client: fix qt error at startup
b525493 
The QT_PLUGIN_PATH couldn't find the needed xcb plugin.

See also NixOS#51044
@Ma27 Ma27 mentioned this pull request Jan 22, 2019
Merged
10 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 22, 2019
@flokli
Copy link
Contributor

flokli commented Jan 23, 2019

@Ma27 can you check whether #44047 would fix this too?

@Ma27
Copy link
Member Author

Ma27 commented Jan 23, 2019

I'm currently building nextcloud-client on master with these fixed on top, let's see...

@Ma27
Copy link
Member Author

Ma27 commented Jan 24, 2019

just tested it with the patched and loclaly built QT and it seems to fix the problem as well. Should we wait for this patch to land in master then?

@jtojnar
Copy link
Member

jtojnar commented Jan 24, 2019

See also #54525

@flokli
Copy link
Contributor

flokli commented Jan 25, 2019

Setting QT_PLUGIN_PATH seems to be a quite common workaround.

I guess it doesn't make sense to stall this PR further on the decision between #44047 and #54525.

@flokli flokli merged commit e15beaa into NixOS:master Jan 25, 2019
@flokli
Copy link
Contributor

flokli commented Jan 25, 2019

@Ma27 do you want to backport this to 18.09?

@Ma27 Ma27 deleted the fix-nextcloud-qt-startup branch January 26, 2019 11:33
@Ma27
Copy link
Member Author

Ma27 commented Jan 26, 2019

As nextcloud-client works fine on release-18.09, I guess this is somehow related to the QT 5.12 update and hence no backport should be needed, right?

@flokli
Copy link
Contributor

flokli commented Jan 26, 2019

@Ma27 The bug is about running QT applications from its nix-store path that were built against another qt version than the one part of the current system closure. This is easily reproducible by building the unstable version from a 18.09 system, but the bug should also exists on 18.09.

@Ma27
Copy link
Member Author

Ma27 commented Jan 27, 2019

I'm afraid I initially misunderstood the root cause of the issue, sorry. I just reread the thread now 😅

In that case it makes absolutely sense to backport, I can do this tomorrow :)

@Ma27
Copy link
Member Author

Ma27 commented Jan 27, 2019

backported as 68c0e95. Thanks for reminding me to backport! %)

@caugner caugner mentioned this pull request Apr 22, 2019
Closed
@averelld averelld mentioned this pull request Jul 24, 2019
Merged
10 tasks
averelld pushed a commit to averelld/nixpkgs that referenced this pull request Jul 25, 2019
x2goclient: fix startup
a2904a4 
Fixes the following error:
```
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized.
Reinstalling the application may fix this problem.
```

See also NixOS#54484 and others.
bjornfor pushed a commit that referenced this pull request Jul 26, 2019
@bjornfor
x2goclient: fix startup
289c607 
Fixes the following error:
```
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized.
Reinstalling the application may fix this problem.
```

See also #54484 and others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ma27 @flokli @jtojnar @GrahamcOfBorg