workflows/eval: Make sure to compare against the push run #360274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For PRs whose commits end up as HEAD of master like NixOS@bcc5c14, there might be workflow runs associated with both PRs and pushes. Only the push event is the one that will run fully and should be used to compare against. So far it didn't distinguish between the two events, causing it to sometimes pick the wrong one and then fail to download non-existent artifacts: https://github.com/NixOS/nixpkgs/actions/runs/12092053414/job/33721377179 This commit fixes that by ensuring that the push event result is compared against
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
1 task
nix-owners
bot
requested review from
azuwis,
LeSuisse,
Mic92,
mweinelt,
risicle and
zowoq
github-actions
bot
added
10.rebuild-darwin: 0
TheGiraffe3
approved these changes
Nov 30, 2024
|
Git push to origin failed for release-24.11 with exitcode 1 |
@infinisil ^^ oops :( |
|
Manual backport: #361168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs whose commits end up as HEAD of master like bcc5c14, there might be workflow runs associated with both PRs and pushes.
Only the push event is the one that will run fully and should be used to compare against. So far it didn't distinguish between the two events, causing it to sometimes pick the wrong one and then fail to download non-existent artifacts: https://github.com/NixOS/nixpkgs/actions/runs/12092053414/job/33721377179
This commit fixes that by ensuring that the push event result is compared against
Having a hard time testing this, but for the above commit, this returns a push and a pull request event:
with the pull request one being more recent (that's what
eval.ymlorders it by) and therefore being used here: https://github.com/NixOS/nixpkgs/actions/runs/12092053414/job/33721377179. Adding-f event=pushmakes it only return the onepushevent.Follow-up to #359704
This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.