protonmail-bridge-gui: patch source to support Qt 6.8

[daniel-fahey]

Fixes #350165 (runtime errors encountered when using a version of the GUI built with Qt 6.8). Patches upstream's Qt Modeling Language (QML) files to support Qt 6.8. Proton AG seem unlikely to update upstream to support Qt 6.8 anytime soon.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4744

[daniel-fahey]

Looks like the next release will be patched to support building with Qt 6.8 ProtonMail/proton-bridge#502 (comment)

[Naxdy]

Given that ProtonMail/proton-bridge#502 seems to have been accepted upstream, I think it makes sense to include the contents of that PR as a patch rather than using the sed approach.

[daniel-fahey]

I've replaced my sed scripts with the Arch patches. For (my own) reference I made the patches using:

git remote add proton https://github.com/ProtonMail/proton-bridge.git
git fetch proton pull/502/head:pr-502
git format-patch master..pr-502 \
  --full-index \
  --stat \
  --summary \
  --cover-from-description=message \
  --base=auto \
  --relative=internal/frontend/bridge-gui/

[Naxdy]

Package builds & GUI works again 👍

[aacebedo]

can we merge this if it works ?

[daniel-fahey]

Superseded by #359899

[Phr0stByte]

All of this is very confusing - is there a nixos 24.11 fix? If so, can we just get the fixed one in the 24.11 channels so we can simply just run an update?

[daniel-fahey]

All of this is very confusing - is there a nixos 24.11 fix? If so, can we just get the fixed one in the 24.11 channels so we can simply just run an update?

The backport was merged into the release-24.11 branch yesterday #360778

It's not yet reached the nixos-24.11 branch as of writing (according to https://nixpk.gs/pr-tracker.html?pr=360778)

[Phr0stByte]

All of this is very confusing - is there a nixos 24.11 fix? If so, can we just get the fixed one in the 24.11 channels so we can simply just run an update?

The backport was merged into the release-24.11 branch yesterday #360778

It's not yet reached the nixos-24.11 branch as of writing (according to https://nixpk.gs/pr-tracker.html?pr=360778)

Thanks. Using the flatpak which is working for now, until the fix makes the main nixos channels

[daniel-fahey]

It's just reached nixos-24.11

[Phr0stByte]

It's just reached nixos-24.11

Confirmed - and working perfectly! Thanks!!!