matrix-sliding-sync: drop #350095
Merged
matrix-sliding-sync: drop #350095
+4
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
emilylange
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Thanks! :)
This is something I simply didn't find time for yet.
I initially wanted to wait until F-Droid caught up with the newer Element-X versions that contain the migration hint, but that has since long happened soooo
I agree that we should drop it before branch-off.
Just the two review comments and there is a typo in your commit message: matrid-sliding-sync vs matrix-sliding-sync
On the 2024 matrix conference the EOL for the sliding-sync-proxy was announced to be 2024-10-15. While the repo does not yet reflect that state, we should not be taking the the sliding-sync proxy into NixOS 24.11 under any circumstances.
mweinelt
force-pushed
the
yank-sliding-sync-proxy
branch
from
531be0f
to
6306bf7
Compare
|
Changes applied. |
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
SuperSandro2000
added a commit
to NuschtOS/nixos-modules
that referenced
this pull request
Oct 20, 2024
|
For people that still want sliding sync with dendrite. Here is the revert: aed993733203 Dendrite doesn't receive many features these days, but it is still maintained until the funding situation improves: matrix-org/dendrite#3413 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the 2024 matrix conference the EOL for the sliding-sync-proxy was announced to be 2024-10-15. While the repo does not yet reflect that state, we should not be taking the the sliding-sync proxy into NixOS 24.11 under any circumstances.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.