Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpifs: init at 0-unstable-2020-05-07 #348768

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

KSJ2000
Copy link
Contributor

@KSJ2000 KSJ2000 commented Oct 15, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Noodlez1232
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348768


x86_64-linux

✅ 1 package built:
  • dumpifs

@Noodlez1232
Copy link
Contributor

I couldn't test functionality, but it seems to build and run

@KSJ2000 KSJ2000 force-pushed the dumpifs branch 2 times, most recently from 83067d2 to 923951e Compare November 2, 2024 11:56
@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 2, 2024
@KSJ2000 KSJ2000 marked this pull request as draft November 12, 2024 08:38
@KSJ2000 KSJ2000 force-pushed the dumpifs branch 2 times, most recently from 66a6731 to 6965059 Compare November 12, 2024 08:58
@KSJ2000 KSJ2000 marked this pull request as ready for review November 12, 2024 08:59
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 12, 2024
@KSJ2000 KSJ2000 marked this pull request as draft November 14, 2024 08:28
@KSJ2000 KSJ2000 marked this pull request as ready for review November 14, 2024 08:40
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Nov 14, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@KSJ2000 KSJ2000 requested a review from tomodachi94 November 21, 2024 12:46
@FliegendeWurst FliegendeWurst merged commit b737b28 into NixOS:master Dec 19, 2024
32 checks passed
@KSJ2000 KSJ2000 deleted the dumpifs branch December 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants