release-lib: add exception to build olm on hydra #347899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we go just with |
ofborg
bot
added
10.rebuild-darwin: 0
Do we not want to allow it for every release? There are 7 release files, so I think it makes sense to have a single place where to add exceptions. |
|
As longs as it is cached by the nixpkgs/trunk builds that should be sufficient. |
rnhmjoj
force-pushed
the
pr-nheko-cache
branch
from
c3b1f63 to
8936e9a
Compare
|
Done as in b0b4d2d. |
mweinelt
reviewed
Oct 12, 2024
Olm was marked as vulnerable in e4767b4. The issue, however, is controversial and the practical ability to exploit its vulnerabilities has not been demostrated: ultimately the users are invited to decide for themselves. Given that, hydra should still build and distribute the packages depending on olm to avoid expensive builds in the event the users decide it's acceptable to continue using these packages.
rnhmjoj
force-pushed
the
pr-nheko-cache
branch
from
8936e9a to
12b1a23
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Olm was marked as vulnerable in e4767b4.
The issue, however, is controversial and the practical ability to exploit its vulnerabilities has not been demostrated: ultimately the users are invited to decide for themselves.
Given that, hydra should still build and distribute the packages depending on olm to avoid expensive builds in the event the users decide it's acceptable to continue using these packages.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Note: this change was split off of #341831