Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feishin: 0.9.0 -> 0.10.1 #344865

Merged
merged 3 commits into from
Oct 6, 2024
Merged

feishin: 0.9.0 -> 0.10.1 #344865

merged 3 commits into from
Oct 6, 2024

Conversation

jlbribeiro
Copy link
Member

@jlbribeiro jlbribeiro commented Sep 27, 2024 •
edited
Loading

Description of changes

Diff: jeffvli/feishin@v0.9.0...v0.10.1
Changelog:

Maintainers: @onny (and @jlbribeiro, me)

Release notes include

Important for Navidrome: v0.10.0 removes support for Navidrome < v0.53.2 due to sort mappings changing in its API.

Given jeffvli/feishin#754 and jeffvli/feishin#764, I added a release note.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jlbribeiro jlbribeiro marked this pull request as draft September 27, 2024 12:23
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: changelog labels Oct 1, 2024
@jlbribeiro jlbribeiro changed the title feishin: 0.9.0 -> 0.10.0 feishin: 0.9.0 -> 0.10.1 Oct 1, 2024
@jlbribeiro jlbribeiro marked this pull request as ready for review October 1, 2024 05:26
@jlbribeiro
Copy link
Member Author

jlbribeiro commented Oct 1, 2024 •
edited
Loading

@onny added a release note regarding the Navidrome version constraint introduced by v0.10.0 + updated to v0.10.1.
(I kept the version bumps separate, unsure whether there's a convention/practice about this.)

@onny
Copy link
Contributor

onny commented Oct 6, 2024

Thanks, builds and works fine for me 👍

@onny onny merged commit c566a36 into NixOS:master Oct 6, 2024
33 checks passed
@jlbribeiro jlbribeiro deleted the pkgs/feishin branch October 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onny onny Awaiting requested review from onny

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlbribeiro @onny