Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kazv: init at 0.5.0 #334844

Merged
merged 2 commits into from
Sep 6, 2024
Merged

kazv: init at 0.5.0 #334844

merged 2 commits into from
Sep 6, 2024

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Aug 15, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4407

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 15, 2024
];

cmakeFlags = [
# Catch2::Catch2WithMain target isn't found
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because we have no catch2 in the dependencies?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's the error I get with catch2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use nix but https://github.com/XYenon/nur-packages has a packaging of kazv & libkazv, you might want to refer to that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! fixed.

];

cmakeFlags = [
# Catch2::Catch2WithMain target isn't found
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olm
qt6.qtbase
qt6.qtmultimedia
qt6.qtwayland
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qtimageformats is a recommended runtime dependency, without which it cannot display certain images like webp.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@fgaz fgaz force-pushed the kazv/init branch 3 times, most recently from 19c0557 to d849c6a Compare August 22, 2024 13:27
@fgaz
Copy link
Member Author

fgaz commented Sep 5, 2024

Ping

@Aleksanaa Aleksanaa merged commit 1f70e0f into NixOS:master Sep 6, 2024
26 checks passed
@fgaz fgaz deleted the kazv/init branch September 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants