-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kazv: init at 0.5.0 #334844
kazv: init at 0.5.0 #334844
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4407 |
pkgs/by-name/li/libkazv/package.nix
Outdated
]; | ||
|
||
cmakeFlags = [ | ||
# Catch2::Catch2WithMain target isn't found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe because we have no catch2 in the dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately that's the error I get with catch2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use nix but https://github.com/XYenon/nur-packages has a packaging of kazv & libkazv, you might want to refer to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/XYenon/nur-packages/blob/master/pkgs/libkazv/default.nix
it's catch2_3
, not catch2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! fixed.
pkgs/by-name/li/libkazv/package.nix
Outdated
]; | ||
|
||
cmakeFlags = [ | ||
# Catch2::Catch2WithMain target isn't found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/XYenon/nur-packages/blob/master/pkgs/libkazv/default.nix
it's catch2_3
, not catch2
.
olm | ||
qt6.qtbase | ||
qt6.qtmultimedia | ||
qt6.qtwayland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qtimageformats is a recommended runtime dependency, without which it cannot display certain images like webp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
19c0557
to
d849c6a
Compare
Ping |
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.