-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cinny-desktop: 4.0.3 -> 4.1.0, use hashRouter #334805
Conversation
Result of 1 package built:
|
#334638 is merged now, should we wait on this? |
Please don’t hold off on continuing to maintain and update these packages; that’s completely fine. The point of the libolm PR is just to offer users a warning about the current state of the cryptography library, and I fully expect that many will make their own threat assessment and choose to override it to continue using their preferred clients, which is totally okay. We don’t have any plans to deprecate or remove these clients given that the ecosystem is still in flux and working on migrating to other options. I’m sorry for the inconvenience to users of these packages, though; sadly |
Ah, thanks for clarifying that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cinny-desktop does fail to build on macOS, but unrelated to this PR, and this does fix the issue on Linux
Yes, it's related to this: #335334 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also need to update web? tauri got reverted back to 1 on master.
Web was updated in #332619 |
ec00aa1
to
b26ca1d
Compare
It's now failing to launch on Wayland (curiously, even with
|
Can't reproduce, launches just fine for me. |
I'm getting some launch failure or another on KWin and Weston, Intel or Nvidia, |
I'm on KDE Plasma 6 (Wayland) with the beta Nvidia driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, but probably just an issue with my setup.
I have the same problem. Want to add that terminal gives the following msg related to olm.
|
Description of changes
Follow up to #331078, I was unable to rebase on top of current master due to many thousands of merge conflicts.
Updates cinny-desktop to 4.1.0, see changes: https://github.com/cinnyapp/cinny-desktop/releases/tag/v4.1.0
Closes #334631 and #329859.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.