Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinny-desktop: 4.0.3 -> 4.1.0, use hashRouter #334805

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

ryand56
Copy link
Member

@ryand56 ryand56 commented Aug 15, 2024

Description of changes

Follow up to #331078, I was unable to rebase on top of current master due to many thousands of merge conflicts.
Updates cinny-desktop to 4.1.0, see changes: https://github.com/cinnyapp/cinny-desktop/releases/tag/v4.1.0
Closes #334631 and #329859.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ryand56 ryand56 marked this pull request as ready for review August 15, 2024 08:26
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 15, 2024
@ofborg ofborg bot requested a review from Qyriad August 15, 2024 08:36
@ryand56 ryand56 removed the 8.has: package (new) This PR adds a new package label Aug 15, 2024
@Guanran928
Copy link
Contributor

Result of nixpkgs-review pr 334805 run on x86_64-linux 1

1 package built:
  • cinny-desktop

@Guanran928
Copy link
Contributor

Guanran928 commented Aug 16, 2024

I'm getting this error when I start cinny-desktop?
image

pkgs/by-name/ci/cinny-desktop/package.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 16, 2024
@ofborg ofborg bot requested a review from Qyriad August 16, 2024 20:01
@ryand56 ryand56 removed the 8.has: package (new) This PR adds a new package label Aug 16, 2024
@ryand56
Copy link
Member Author

ryand56 commented Aug 16, 2024

#334638 is merged now, should we wait on this?

@ryand56 ryand56 marked this pull request as draft August 16, 2024 20:31
@emilazy
Copy link
Member

emilazy commented Aug 16, 2024

Please don’t hold off on continuing to maintain and update these packages; that’s completely fine. The point of the libolm PR is just to offer users a warning about the current state of the cryptography library, and I fully expect that many will make their own threat assessment and choose to override it to continue using their preferred clients, which is totally okay. We don’t have any plans to deprecate or remove these clients given that the ecosystem is still in flux and working on migrating to other options. I’m sorry for the inconvenience to users of these packages, though; sadly knownVulnerabilities is the only real way we have to inform users about security risks they should be aware of.

@ryand56
Copy link
Member Author

ryand56 commented Aug 16, 2024

Please don’t hold off on continuing to maintain and update these packages; that’s completely fine. The point of the libolm PR is just to offer users a warning about the current state of the cryptography library, and I fully expect that many will make their own threat assessment and choose to override it to continue using their preferred clients, which is totally okay. We don’t have any plans to deprecate or remove these clients given that the ecosystem is still in flux and working on migrating to other options. I’m sorry for the inconvenience to users of these packages, though; sadly knownVulnerabilities is the only real way we have to inform users about security risks they should be aware of.

Ah, thanks for clarifying that :)

@ryand56 ryand56 marked this pull request as ready for review August 16, 2024 20:45
Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cinny-desktop does fail to build on macOS, but unrelated to this PR, and this does fix the issue on Linux

@ryand56
Copy link
Member Author

ryand56 commented Aug 18, 2024

cinny-desktop does fail to build on macOS, but unrelated to this PR, and this does fix the issue on Linux

Yes, it's related to this: #335334

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to update web? tauri got reverted back to 1 on master.

pkgs/by-name/ci/cinny-desktop/package.nix Show resolved Hide resolved
@ryand56
Copy link
Member Author

ryand56 commented Aug 18, 2024

Don't we also need to update web? tauri got reverted back to 1 on master.

Web was updated in #332619

@ryand56 ryand56 marked this pull request as draft August 18, 2024 21:55
@ryand56 ryand56 force-pushed the update/cinny-desktop branch from ec00aa1 to b26ca1d Compare August 18, 2024 22:02
@ryand56 ryand56 marked this pull request as ready for review August 18, 2024 22:10
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 18, 2024
@ofborg ofborg bot requested a review from Qyriad August 18, 2024 23:38
@ryand56 ryand56 removed the 8.has: package (new) This PR adds a new package label Aug 18, 2024
@Qyriad
Copy link
Member

Qyriad commented Aug 19, 2024

It's now failing to launch on Wayland (curiously, even with WAYLAND_DISPLAY unset):

** (cinny:1305176): WARNING **: 12:11:56.501: webkit_settings_set_enable_offline_web_application_cache is deprecated and does nothing.
Gtk-Message: 12:11:57.056: Failed to load module "appmenu-gtk-module": 'gtk_module_display_init': /run/current-system/sw/lib/gtk-3.0/modules/libcolorreload-gtk-module.so: undefined symbol: gtk_module_display_init
Gtk-Message: 12:11:57.186: Failed to load module "appmenu-gtk-module": 'gtk_module_display_init': /run/current-system/sw/lib/gtk-3.0/modules/libcolorreload-gtk-module.so: undefined symbol: gtk_module_display_init
Gdk-Message: 12:11:57.639: Error 71 (Protocol error) dispatching to Wayland display.

@ryand56
Copy link
Member Author

ryand56 commented Aug 19, 2024

It's now failing to launch on Wayland (curiously, even with WAYLAND_DISPLAY unset):

** (cinny:1305176): WARNING **: 12:11:56.501: webkit_settings_set_enable_offline_web_application_cache is deprecated and does nothing.
Gtk-Message: 12:11:57.056: Failed to load module "appmenu-gtk-module": 'gtk_module_display_init': /run/current-system/sw/lib/gtk-3.0/modules/libcolorreload-gtk-module.so: undefined symbol: gtk_module_display_init
Gtk-Message: 12:11:57.186: Failed to load module "appmenu-gtk-module": 'gtk_module_display_init': /run/current-system/sw/lib/gtk-3.0/modules/libcolorreload-gtk-module.so: undefined symbol: gtk_module_display_init
Gdk-Message: 12:11:57.639: Error 71 (Protocol error) dispatching to Wayland display.

Can't reproduce, launches just fine for me.

@Qyriad
Copy link
Member

Qyriad commented Aug 20, 2024

I'm getting some launch failure or another on KWin and Weston, Intel or Nvidia, GDK_BACKEND=x11 or Wayland. What compositor and graphics driver are you on?

@ryand56
Copy link
Member Author

ryand56 commented Aug 20, 2024

I'm getting some launch failure or another on KWin and Weston, Intel or Nvidia, GDK_BACKEND=x11 or Wayland. What compositor and graphics driver are you on?

I'm on KDE Plasma 6 (Wayland) with the beta Nvidia driver.

Copy link
Member

@Qyriad Qyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, but probably just an issue with my setup.

@zincentimeter
Copy link

I'm getting this error when I start cinny-desktop? image

I have the same problem. Want to add that terminal gives the following msg related to olm.
The author said that upgrading to 4.1.0 will fix this. Hope this get merged ASAP.

** (cinny:316869): WARNING **: 11:11:57.274: webkit_settings_set_enable_offline_web_application_cache is deprecated and does nothing.
Asset `home/olm.wasm` not found; fallback to home/olm.wasm.html
Asset `home/olm.wasm` not found; fallback to home/olm.wasm.html

@emilazy emilazy merged commit 7fd9224 into NixOS:master Aug 27, 2024
27 checks passed
@ryand56 ryand56 deleted the update/cinny-desktop branch August 27, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cinny-desktop : Failed to load.
7 participants