Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kime: 3.0.2 -> 3.1.1 #334078

Merged
merged 1 commit into from
Aug 19, 2024
Merged

kime: 3.0.2 -> 3.1.1 #334078

merged 1 commit into from
Aug 19, 2024

Conversation

honnip
Copy link
Contributor

@honnip honnip commented Aug 12, 2024

Description of changes

Riey/kime@v3.0.2...v3.1.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from Riey August 12, 2024 07:55
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 12, 2024
@honnip
Copy link
Contributor Author

honnip commented Aug 12, 2024

Tested on GNOME with GTK_IM_MODULE=kime gnome-text-editor

@honnip honnip marked this pull request as ready for review August 12, 2024 08:17
@honnip honnip added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 12, 2024
@nakoo
Copy link

nakoo commented Aug 14, 2024

Please consider to use mkDerivation finalAttrs.

mkDerivation finalAttrs makes it possible to use overrideAttrs properly unlike rec.
It's current recommendation model of nixpkgs and there is ongoing discussion to replace rec automatically.

Notes:
#119942
#293452 (comment)

Related PR:
Riey/kime#682

@honnip honnip removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 15, 2024
@ofborg ofborg bot requested a review from Riey August 15, 2024 03:34
@honnip honnip added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 16, 2024
@smancill smancill merged commit 429ea13 into NixOS:master Aug 19, 2024
30 of 31 checks passed
@honnip honnip deleted the update-kime branch August 19, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants