nixos/keymapper: init module #328921
Open
nixos/keymapper: init module #328921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
felbinger
suggested changes
Jul 22, 2024
| , lib | ||
| , ... | ||
| }: | ||
| with lib; |
There was a problem hiding this comment.
use inherit (lib) mkOption types ...; instead, see #208242
| in | ||
| { | ||
| options.services.keymapper = { | ||
| enable = lib.mkEnableOption null // { |
There was a problem hiding this comment.
replace null with "keymapper", to generate documentation correctly
felbinger
approved these changes
Jul 22, 2024
|
@ofborg test keymapper |
h7x4
added
8.has: module (new)
spitulax
force-pushed
the
keymapper-module
branch
from
2966734 to
db4a58d
Compare
|
A github workflow has been adjusted (#326407), could you trigger the ci again by pushing a new commit? |
|
The new Github workflow should have been run though. I checked the Github action on commit |
|
@spitulax Just so you know, you need to cleanup the commit history (by git rebase), before this can be reviewed and merged. |
Added option to enable `keymapperd` service used to provide communication between the user-level program `keymapper` which needs permission to grab keyboard and inject keys.
spitulax
force-pushed
the
keymapper-module
branch
from
cd69bad to
39f0395
Compare
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added NixOS module services.keymapper to enable
keymapperdservice used to provide communication between the user-level programkeymapperwhich needs permission to grab keyboard and inject keys.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.