Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test-pkgs, buildPackages, and buildFreebsd from excluded-attrnames-at-any-depth #324696

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

There is no difference in the package names generated.

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 5, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but I tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@philiptaron philiptaron force-pushed the __attrsFailEvaluation/excluded-attrnames-at-any-depth branch from 839a394 to 48d1364 Compare July 26, 2024 00:29
@philiptaron
Copy link
Contributor Author

Thanks, rebased.

@infinisil infinisil merged commit ae53779 into NixOS:master Jul 27, 2024
21 checks passed
@paparodeo
Copy link
Contributor

paparodeo commented Nov 6, 2024

removing test-pkgs seems like it creates a cycle in freshBootstrapTools.test-pkgs as shown by:

nix-instantiate  --eval --strict -E '(import ./pkgs/top-level/release-attrpaths-superset.nix { }).paths'  

restored in #354004

@philiptaron philiptaron deleted the __attrsFailEvaluation/excluded-attrnames-at-any-depth branch November 7, 2024 15:13
@philiptaron
Copy link
Contributor Author

PR immediately accepted and merged. I bet you're on Darwin. All my testing (and the CI checks) are on x86_64-linux, and I've noticed that these tests are incredibly sensitive to which system they're evaluated for.

@paparodeo
Copy link
Contributor

paparodeo commented Nov 7, 2024

definitely was running on darwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants