Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages: remove __attrsFailEvaluation since the attrset evaluates #324688

Merged

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/4db141eb60b787b11a8d413dc52598ab

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jul 4, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 5, 2024
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but I tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@philiptaron philiptaron force-pushed the __attrsFailEvaluation/linuxKernel branch from 83f3589 to 38ffd73 Compare July 26, 2024 00:33
@philiptaron
Copy link
Contributor Author

Thanks, rebased.

@infinisil infinisil merged commit b6a3ee7 into NixOS:master Jul 27, 2024
22 checks passed
@philiptaron
Copy link
Contributor Author

Whew, I didn't erroneously remove any recurseIntoAttrs here.

@infinisil
Copy link
Member

Can confirm, master works :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants