Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: move __attrsFailEvaluation to allow deeper inspection #324682

Merged
merged 1 commit into from
Jul 26, 2024
Merged

pythonPackages: move __attrsFailEvaluation to allow deeper inspection #324682

merged 1 commit into from
Jul 26, 2024

Conversation

philiptaron
Copy link
Contributor

Description of changes

The test (nix-build pkgs/test/release/default.nix) continues to pass.

These lines were added in #269356.

New derivations reported: https://gist.github.com/philiptaron/918e9ec33ec9e9eddf6c23639643dbb9

Things done

  • Tested, as applicable:
    • nix-build pkgs/test/release/default.nix
  • Fits CONTRIBUTING.md.

@philiptaron philiptaron requested a review from natsukium as a code owner July 4, 2024 21:51
@philiptaron philiptaron mentioned this pull request Jul 4, 2024
Open
36 tasks
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 4, 2024
infinisil
infinisil approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix-build pkgs/test/release when merging this into current master, still works, so this LGTM!

@infinisil infinisil merged commit 29016e9 into NixOS:master Jul 26, 2024
24 checks passed
@philiptaron philiptaron deleted the __attrsFailEvaluation/python branch July 26, 2024 15:58
@philiptaron
Copy link
Contributor Author

I accidentally removed recurseIntoAttrs for Python 3.11 and 3.12. @mweinelt fixed it in #330205.

@philiptaron philiptaron mentioned this pull request Sep 7, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philiptaron @infinisil