Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble: unpin protobuf #322756

Merged
merged 1 commit into from
Jun 30, 2024
Merged

mumble: unpin protobuf #322756

merged 1 commit into from
Jun 30, 2024

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Jun 26, 2024

fixes pkgsMusl.mumble after musl 1.2.5 upgrade (#229439)

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yu-re-ka yu-re-ka requested a review from alyssais June 26, 2024 22:55
@alyssais alyssais requested a review from K900 June 26, 2024 23:10
@ofborg ofborg bot requested review from felixsinger and Lilacious June 26, 2024 23:49
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 26, 2024
@felixsinger
Copy link
Member

Did you test this before? The VM tests are failing.

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Jun 27, 2024 via email

@felixsinger
Copy link
Member

It seems the CI built it, but the execution failed. I can try looking at it tomorrow.

@alyssais alyssais mentioned this pull request Jun 27, 2024
47 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 27, 2024
fixes pkgsMusl.mumble after musl 1.2.5 upgrade
@yu-re-ka
Copy link
Contributor Author

Looking at the CI logs again, it was the server (murmur) which still failed to build, since I only added the new cmake flag to the client expression.

@yu-re-ka yu-re-ka merged commit 5b3bbb9 into NixOS:master Jun 30, 2024
26 checks passed
@yu-re-ka yu-re-ka deleted the musl-mumble branch June 30, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants