-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/filebeat: Improve options #322425
base: master
Are you sure you want to change the base?
nixos/filebeat: Improve options #322425
Conversation
c1d37b7
to
db4548e
Compare
6604677
to
ecf1834
Compare
ecf1834
to
086301e
Compare
8bfb5f1
to
bd7f7d3
Compare
f04fcab
to
fd2bd02
Compare
fd2bd02
to
7f46f04
Compare
@SuperSandro2000 Is it possible to set default values for Do you see any other way to accomplish this without removing the default option (which again is a breaking change)? Is there also a simpler solution to filter the outputs attrs to only get the enabled (see code)? |
7f46f04
to
1e93d4e
Compare
description = '' | ||
The input type. | ||
default = { }; | ||
type = types.attrsOf ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the module system will now properly merge this.
I think this could be similar to 490ba58 but not fully sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is working. I tested a couple configurations and just had one issue with an assertion. Also this is nothing I changed in this commit, it was just changed due to new formatting standard which has been introduced in #326407.
1e93d4e
to
39fbea0
Compare
39fbea0
to
b18d21f
Compare
Description of changes
The implemented nixos options for filebeat could be improved.
I had trouble finding a way to disable the elasticsearch output in the first place, which was the main reason to open this pr, see: #280535
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.