-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.certomancer 0.11.0 -> 0.12.0 #304985
Conversation
89c9784
to
e717533
Compare
Result of 12 packages failed to build:
4 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3850 |
Result of 12 packages failed to build:
4 packages built:
|
Hold on, what makes us think this is just "broken tests" on 3.12 and not breakage of the features behind them? |
After reviewing the changes upstream and related resources, I think we cannot take this issue lightly.
I believe a better approach is to disable the Sorry for linking it to ZHF without sufficient consideration. |
I opened #315532 and then discovered this PR. |
Description of changes
Bumped version to 0.12.0 and disabled 1 broken test.
Several tests are broken on Python 3.12 and there is an open issue to fix it.
MatthiasValvekens/certomancer#12
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.