Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.nixpkgs-check-by-name: Remove now that a separate repo is used #299301

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Mar 26, 2024

Description of changes

Since #297901, the tool is fetched from https://github.com/NixOS/nixpkgs-check-by-name, so there's no need to keep it around in Nixpkgs anymore. This is the last step to addressing #286559.

This work is sponsored by Antithesis

Things done

  • Added a warning for the removed attribute
    • Not strictly necessary, since tests.* shouldn't be considered a stable API, but it doesn't hurt

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

It was not removed in NixOS#297901 so
that CI for that PR itself would not fail since CI runs from the base
branch.
Since NixOS#297901, the tool is fetched
from https://github.com/NixOS/nixpkgs-check-by-name, so there's no need
to keep it around in Nixpkgs anymore
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only 🟥 , I say ✅ .

@infinisil infinisil added this to the RFC 140 milestone Mar 26, 2024
@infinisil infinisil linked an issue Mar 26, 2024 that may be closed by this pull request
@infinisil infinisil merged commit a4caf2a into NixOS:master Mar 26, 2024
7 of 8 checks passed
@infinisil infinisil deleted the check-by-name-remove branch March 26, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move nixpkgs-check-by-name to a separate repository
2 participants