-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgs/by-name
: Enable gradual migration checks and add run-local.sh
#274591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
infinisil
force-pushed
the
by-name-reproducible
branch
from
December 19, 2023 02:07
96acead
to
1025f21
Compare
infinisil
changed the title
Make pkgs/by-name check as reproducible as possible, and prepare for
Make pkgs/by-name check as reproducible as possible, and pass Dec 19, 2023
--base
--base
This part of the CI can also be reproduced locally
infinisil
force-pushed
the
by-name-reproducible
branch
from
December 19, 2023 22:21
1025f21
to
63a27c1
Compare
infinisil
changed the title
Make pkgs/by-name check as reproducible as possible, and pass
Dec 19, 2023
--base
pkgs/by-name
: Enable gradual migration checks and add run-local.sh
infinisil
force-pushed
the
by-name-reproducible
branch
2 times, most recently
from
December 19, 2023 22:31
3f3080f
to
cc0fe3b
Compare
This was referenced Dec 20, 2023
roberth
reviewed
Dec 20, 2023
Due to the check soon depending on the base branch (see `--base`), the CI check can't reasonably share all code with a local check. We can still make a script to run it locally, just not sharing all code.
Now that we have a script to run the check locally, there's no real need to output the information to reproduce anymore, which allows cleaning up the CI workflow. Furthermore, this prepares the CI workflow to be passed `--base`, as introduced recently.
This enables the ratchet checks for pkgs/by-name, allowing gradual migrations!
infinisil
force-pushed
the
by-name-reproducible
branch
from
December 20, 2023 16:38
cc0fe3b
to
1968bee
Compare
l0b0
reviewed
Dec 21, 2023
l0b0
reviewed
Dec 21, 2023
l0b0
reviewed
Dec 21, 2023
l0b0
reviewed
Dec 21, 2023
l0b0
approved these changes
Dec 21, 2023
delroth
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Dec 21, 2023
- trace function, avoids littering `echo >&2` all throughout - Avoid `eval`, remove unneeded shellcheck Co-Authored-By: Victor Engmark <[email protected]>
infinisil
force-pushed
the
by-name-reproducible
branch
from
December 21, 2023 23:06
b62b605
to
e130ee3
Compare
I'll merge this, because:
This allows me to proceed with finalising the next step for RFC 140: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: policy discussion
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After #272395 extended the
nixpkgs-check-by-name
tool to have gradual migration checking, aka ratchet checks, this PR now enables them by passing the--base
flag to the tool.Furthermore, this is a really good opportunity to make the CI check runnable locally, solving #266931 as well as possible, replacing #266937.
Fundamentally it's impossible to make it fully reproducible because the base branch fetching/merging can't happen in the same way, but this PR makes everything be shared that can be shared between CI and the local run.
It's not perfect, but better than nothing.
Things done
Add a 👍 reaction to pull requests you find important.