Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcloud: 1.14.0 -> 1.14.1 #261790

Merged
merged 1 commit into from
Oct 18, 2023
Merged

pcloud: 1.14.0 -> 1.14.1 #261790

merged 1 commit into from
Oct 18, 2023

Conversation

r-vdp
Copy link
Contributor

@r-vdp r-vdp commented Oct 18, 2023

Description of changes

https://www.pcloud.com/release-notes/linux.html

pcloud is still broken (see #226339), but having an up-to-date version in nixpkgs makes local overrides to get it to work easier (those work-arounds are not suitable for inclusion in nixpkgs).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-vdp r-vdp requested a review from Patryk27 October 18, 2023 10:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 18, 2023
Copy link
Member

@Patryk27 Patryk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 18, 2023
@NickCao NickCao merged commit 2a2a824 into NixOS:master Oct 18, 2023
12 of 13 checks passed
@nadir-ishiguro
Copy link
Contributor

nadir-ishiguro commented Oct 27, 2023

How does this make local overrides easier? I'm currently using an overlay using nixpkgs 22_11 with the updated code and hash to get it working.

It's convenient to get the current hash from here, but I'm not sure if I'm missing some other way this should make it easier for me.

@Patryk27
Copy link
Member

Patryk27 commented Oct 28, 2023

You can just take src out of the newest derivation - i.e. something like this should do it:

system.environmentPackages = [
  (older-nixpkgs.pcloud.override {
    src = nixpkgs-master.pcloud.src;
  })
];

@r-vdp r-vdp deleted the rvdp/pcloud_1_14_1 branch October 28, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants