-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dmd: build using gcc11Stdenv #230827
Merged
Merged
dmd: build using gcc11Stdenv #230827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from trofi
May 9, 2023 07:50
ghost
added
the
0.kind: ZHF Fixes
Fixes during the Zero Hydra Failures (ZHF) campaign
label
May 9, 2023
@ofborg build dmd dmd.passthru.tests |
wegank
previously approved these changes
May 9, 2023
wegank
reviewed
May 9, 2023
trofi
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i agree we should not override stdenv at least for darwin.
mweinelt
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
May 9, 2023
Without the change autopatchelf fails to find the dependency as: searching for dependencies of ...-dmd-bootstrap-2.090.1/bin/dmd libgcc_s.so.1 -> not found! auto-patchelf: 6 dependencies could not be satisfied Full build log: https://hydra.nixos.org/log/plma45m19p0cm1i04c4qzmfi54n38ydk-dmd-bootstrap-2.090.1.drv
The DMD test suite has been failing since we updated to gcc12, as reported by @trofi: #206907 (comment) Let's use gcc11Stdenv for now.
Squashed (into two commits instead of three), rebased. |
Waiting for ofborg-eval to finish, then I will merge this. |
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
May 10, 2023
ghost
deleted the
zhf/dmd
branch
May 10, 2023 05:21
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.kind: ZHF Fixes
Fixes during the Zero Hydra Failures (ZHF) campaign
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The DMD test suite has been failing since we updated to gcc12, as
reported by @trofi:
#206907 (comment)
Let's use gcc11Stdenv for now.
#230712
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)