Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmd: build using gcc11Stdenv #230827

Merged
2 commits merged into from May 10, 2023
Merged

dmd: build using gcc11Stdenv #230827

2 commits merged into from May 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2023

Description of changes

The DMD test suite has been failing since we updated to gcc12, as
reported by @trofi:

#206907 (comment)

Let's use gcc11Stdenv for now.

#230712

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from trofi May 9, 2023 07:50
@ghost ghost added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 9, 2023
@wegank
Copy link
Member

wegank commented May 9, 2023

@ofborg build dmd dmd.passthru.tests

wegank
wegank previously approved these changes May 9, 2023
@wegank wegank dismissed their stale review May 9, 2023 08:27

Causes darwin rebuilds

Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i agree we should not override stdenv at least for darwin.

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 9, 2023
trofi and others added 2 commits May 9, 2023 20:25
Without the change autopatchelf fails to find the dependency as:

    searching for dependencies of ...-dmd-bootstrap-2.090.1/bin/dmd
        libgcc_s.so.1 -> not found!
    auto-patchelf: 6 dependencies could not be satisfied

Full build log: https://hydra.nixos.org/log/plma45m19p0cm1i04c4qzmfi54n38ydk-dmd-bootstrap-2.090.1.drv
The DMD test suite has been failing since we updated to gcc12, as
reported by @trofi:

  #206907 (comment)

Let's use gcc11Stdenv for now.
@ghost
Copy link
Author

ghost commented May 10, 2023

Squashed (into two commits instead of three), rebased.

@ghost
Copy link
Author

ghost commented May 10, 2023

Waiting for ofborg-eval to finish, then I will merge this.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels May 10, 2023
@ghost ghost merged commit b53b2f2 into NixOS:master May 10, 2023
@ghost ghost deleted the zhf/dmd branch May 10, 2023 05:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants