Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

musl: 1.2.3 -> 1.2.5 #229439

Merged
merged 3 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/development/libraries/abseil-cpp/202103.nix
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,7 @@ stdenv.mkDerivation rec {
license = licenses.asl20;
platforms = platforms.all;
maintainers = [ maintainers.andersk ];
# Requires LFS64 APIs. 202401 and later are fine.
broken = stdenv.hostPlatform.isMusl;
};
}
2 changes: 2 additions & 0 deletions pkgs/development/libraries/abseil-cpp/202301.nix
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,7 @@ stdenv.mkDerivation (finalAttrs: {
license = licenses.asl20;
platforms = platforms.all;
maintainers = [ maintainers.andersk ];
# Requires LFS64 APIs. 202401 and later are fine.
broken = stdenv.hostPlatform.isMusl;
};
})
6 changes: 0 additions & 6 deletions pkgs/development/libraries/gsasl/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ stdenv.mkDerivation (finalAttrs: {
sha256 = "sha256-1FtWLhO9E7n8ILNy9LUyaXQM9iefg28JzhG50yvO4HU=";
};

# This is actually bug in musl. It is already fixed in trunc and
# this patch won't be necessary with musl > 1.2.3.
#
# https://git.musl-libc.org/cgit/musl/commit/?id=b50eb8c36c20f967bd0ed70c0b0db38a450886ba
patches = lib.optional stdenv.hostPlatform.isMusl ./gsasl.patch;

buildInputs = [ libidn libkrb5 ];

configureFlags = [ "--with-gssapi-impl=mit" ];
Expand Down
21 changes: 0 additions & 21 deletions pkgs/development/libraries/gsasl/gsasl.patch

This file was deleted.

9 changes: 0 additions & 9 deletions pkgs/development/libraries/libtasn1/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{ lib
, stdenv
, fetchurl
, fetchpatch
, perl
, texinfo

Expand All @@ -20,14 +19,6 @@ stdenv.mkDerivation rec {
sha256 = "sha256-FhPwrBz0hNbsDOO4wG1WJjzHJC8cI7MNgtI940WmP3o=";
};

# Patch borrowed from alpine to work around a specific test failure with musl libc
# Upstream is patching this test in their own CI because that CI is using alpine and thus musl
# https://github.com/gnutls/libtasn1/commit/06e7433c4e587e2ba6df521264138585a63d07c7#diff-037ea159eb0a7cb0ac23b851e66bee30fb838ee8d0d99fa331a1ba65283d37f7R293
patches = lib.optional stdenv.hostPlatform.isMusl (fetchpatch {
alyssais marked this conversation as resolved.
Show resolved Hide resolved
url = "https://git.alpinelinux.org/aports/plain/main/libtasn1/failed-test.patch?id=aaed9995acc1511d54d5d93e1ea3776caf4aa488";
sha256 = "sha256-GTfwqEelEsGtLEcBwGRfBZZz1vKXRfWXtMx/409YqX8=";
});

outputs = [ "out" "dev" "devdoc" ];
outputBin = "dev";

Expand Down
19 changes: 7 additions & 12 deletions pkgs/os-specific/linux/musl/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ let
in
stdenv.mkDerivation rec {
pname = "musl";
version = "1.2.3";
version = "1.2.5";

src = fetchurl {
url = "https://musl.libc.org/releases/${pname}-${version}.tar.gz";
sha256 = "sha256-fVsLYGJSHkYn4JnkydyCSNMqMChelZt+7Kp4DPjP1KQ=";
sha256 = "qaEYu+hNh2TaDqDSizqz+uhHf8fkCF2QECuFlvx8deQ=";
};

enableParallelBuilding = true;
Expand All @@ -71,12 +71,6 @@ stdenv.mkDerivation rec {
url = "https://raw.githubusercontent.com/openwrt/openwrt/87606e25afac6776d1bbc67ed284434ec5a832b4/toolchain/musl/patches/300-relative.patch";
sha256 = "0hfadrycb60sm6hb6by4ycgaqc9sgrhh42k39v8xpmcvdzxrsq2n";
})

# fix parsing lines with optional fields in fstab etc. NOTE: Remove for the next release since it has been merged upstream
(fetchurl {
url = "https://git.musl-libc.org/cgit/musl/patch/?id=751bee0ee727e8d8b003c87cff77ac76f1dbecd6";
sha256 = "sha256-qCw132TCSaZrkISmtDb8Q8ufyt8sAJdwACkvfwuoi/0=";
})
];
CFLAGS = [ "-fstack-protector-strong" ]
++ lib.optional stdenv.hostPlatform.isPower "-mlong-double-64";
Expand Down Expand Up @@ -151,10 +145,11 @@ stdenv.mkDerivation rec {
license = licenses.mit;
platforms = [
"aarch64-linux" "armv5tel-linux" "armv6l-linux" "armv7a-linux"
"armv7l-linux" "i686-linux" "x86_64-linux" "m68k-linux"
"microblaze-linux" "microblazeel-linux" "mips-linux" "mips64-linux"
"mipsel-linux" "mips64el-linux" "powerpc64-linux" "powerpc64le-linux"
"riscv64-linux" "s390x-linux"
"armv7l-linux" "i686-linux" "loongarch64-linux" "m68k-linux"
"microblaze-linux" "microblazeel-linux" "mips-linux"
"mips64-linux" "mips64el-linux" "mipsel-linux" "powerpc64-linux"
"powerpc64le-linux" "riscv32-linux" "riscv64-linux"
"s390x-linux" "x86_64-linux"
];
maintainers = with maintainers; [ thoughtpolice dtzWill ];
};
Expand Down
14 changes: 0 additions & 14 deletions pkgs/tools/misc/ostree/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{ stdenv
, lib
, fetchurl
, fetchpatch
, pkg-config
, gtk-doc
, gobject-introspection
Expand Down Expand Up @@ -51,19 +50,6 @@ in stdenv.mkDerivation rec {
sha256 = "sha256-Y8kZCCEzOsc3Pg2SPkwnZrJevc/fTvtEy1koxlidn8s=";
};

patches = lib.optionals stdenv.hostPlatform.isMusl [
# > I guess my inclination here is to recommend that musl users
# > carry a downstream patch to revert the commits in #3175 until
# > such time as they can update to the new musl.
# https://github.com/ostreedev/ostree/issues/3200#issuecomment-1974819192
(fetchpatch {
name = "revert-statx.diff";
url = "https://github.com/ostreedev/ostree/commit/f46cc0cd85b564e40e03c7438a41c8e57f6b836c.diff";
excludes = [ "ci/*" ];
revert = true;
hash = "sha256-LsXbRYh4hfjNdt1S384IPlSvtC5f2rgSTZEkIIBkT0g=";
})
];

nativeBuildInputs = [
autoconf
Expand Down