-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xgboost: 1.7.4 -> 1.7.5 #224150
xgboost: 1.7.4 -> 1.7.5 #224150
Conversation
The R CUDA issue might be related to #220341 |
RE: possible relation to the libstdc++ mismatch issue So far we've only observed runtime issues (a process loads gcc11's libstdc++, then dlopen's a library that seeks for symbols from gcc12's libstdc++). Your error message mentions
Footnotes
|
Result of 5 packages failed to build:
|
@SomeoneSerge - thanks for the suggestions. Not sure if I used nixpkgs-review correctly there. I tried updating from the master branch and using #223664, but now I'm having trouble building cudaPackages on my machine. The nixpkgs-review didn't seem to publish the error, but I'll try to share manually soon. xgboost 1.7.5 now requires 11.8, which I'm setting in this PR. I'll keep an eye on CUDA and give this another go soon. |
Re: cuda 11.8 CC #222778 |
Hi, the CUDA requirement is updated to 11.8 only for compatibility with xgboost's binary wheel pipeline. If it's causing too much trouble, a lower version (like 11.5) can be used instead. We haven't backported any CUDA feature related change to the 1.7.5 release. |
Thanks @trivialfis - I'll try rolling back the CUDA version as you suggested. I was waiting to see if #220341 resolved the trouble. Do you see anything wrong with the cmake flags I have set? I originally referenced your work in tests/ci_build/build_r_pkg_with_cuda.sh. Is that script building inside the Centos 7 container with R 3.3.0? The only combination that's failing in this PR is rLibrary + cudaSupport. |
I'm getting the same error with cudaPackages_11_7 now, so it looks like something is going wrong with an input or some sort of library linkage. @Ericson2314, @artturi - xgboost with R/CUDA support started to fail a few weeks ago on the error below. I'm not familiar with icu4c and wondered if you could advise on what I might try to fix the build.
Sorry I'm not able to share a nixpkgs-review, but I didn't know how to override the default arguments to build the rLibrary configuration. |
It's a known error. We partially addressed this with #223664, but since we didn't properly extend Maybe you could try https://github.com/NixOS/nixpkgs/blob/93b1f3fb0cf6303faf15908e5057373aa118ff47/pkgs/development/libraries/science/math/faiss/default.nix#L39 meanwhile |
Thanks for the ideas, @SomeoneSerge. I didn't have any luck with backendStdenv, so I'll keep an eye on #226165. Hopefully, it will do the trick here. |
Odd, cause I think it helped me at least on master: SomeoneSerge@bf67283
|
Wow, thanks for all your tips @SomeoneSerge. The R library is finally building, and I tested against several versions of CUDA. The libstdc++ interactions with CUDA are something I hadn't seen before, and I really appreciate what you're doing with CUDA. I'll have another look at the build once #226165 is ready for a test. This PR is ready for merge. |
Result of 6 packages built:
|
@Mindavi - could you help with a merge? Thank you! |
Description of changes
WIP. Updating xgboost to latest version, including a bump to cudaPackages_11_8. C++ library builds with and without Cuda support, but the R library fails on the error below:
@trivialfis - any suggestions on what I can try next?
Things done