Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotatogram-desktop: unbreak on aarch64-linux #221485

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 16, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Mar 16, 2023

@ofborg build kotatogram-desktop

@wegank wegank force-pushed the kotatogram-desktop-fix branch from 8c4818c to 7db54bd Compare March 16, 2023 13:01
@wegank wegank changed the title kotatogram-desktop: unbreak kotatogram-desktop: unbreak on aarch64-linux Mar 16, 2023
@wegank wegank marked this pull request as ready for review March 16, 2023 13:01
@ofborg ofborg bot requested a review from ilya-fedin March 16, 2023 14:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 16, 2023
@ilya-fedin
Copy link
Contributor

This change doesn't look valid given that #108305 is still open. gcc 9 won't build tdesktop/kotatogram-desktop due to ICE in various C++20 features support.

@wegank
Copy link
Member Author

wegank commented Mar 16, 2023

Oh, forgot to close that issue. aarch64-linux is now on GCC 12.

@ilya-fedin
Copy link
Contributor

Wow, that's really nice

@wegank wegank merged commit a54102e into NixOS:master Mar 16, 2023
@wegank wegank deleted the kotatogram-desktop-fix branch March 16, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants