peertube: add vosk plugin #191497
Open
peertube: add vosk plugin #191497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
This also adds a skeleton for the PeerTube plugins and adds the hello world plugin, which is useful for testing the plugin infrastructure with a minimal example that does not have complicated dependencies.
This uses PeerTube’s plugin management scripts to install plugins from a Nix store path instead of the npm registry. Because they require a populated filesystem and database, it can’t do the setup before PeerTube’s first start. Therefore, it creates two separate systemd services. One is dependent on the files required already existing, which then is started before PeerTube. In the case the filesystem structure is not initialised yet, a service is started and polls for the files to exist. After that, it continues with the plugin installation and imperatively restarts PeerTube to ensure plugin activation. Co-authored-by: a-kenji <[email protected]>
Co-authored-by: a-kenji <[email protected]>
sbruder
force-pushed
the
peertube-vosk
branch
from
477f24e to
47fc3aa
Compare
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds support for the PeerTube transcription plugin using the vosk speech recognition service.
To make this work, it adds plugin infrastructure to PeerTube, both for packages and the NixOS module. To ensure it does not break on upgrades, it also includes a NixOS test for testing the plugin management. While the implementation of the plugin management is not as pretty as it should be, we found no other way to do this because of PeerTube limitations (see the commit messages for more details).
It depends on #186917 for the vosk package and #191494 for making PeerTube work after the switch to openssl 3. It currently is rebased to include commits from both branches, so the changes from those PRs are also shown in the diff.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes