-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdal: 3.4.2 -> 3.5.2 #179406
gdal: 3.4.2 -> 3.5.2 #179406
Conversation
@jtojnar You "recently" touched mysql-workbench. Do you have a suggestion how to fix it?
The relevant code is in
|
c8d4e09
to
26ae88b
Compare
Continue using
or even
since |
Result of 7 packages marked as broken and skipped:
20 packages failed to build:
75 packages built:
|
The rasterio failure is probably due to OSGeo/gdal#6004. |
Note that there is now a PR for a version bump of GEOS at #181988. |
Result of 18 packages marked as broken and skipped:
35 packages failed to build:
24 packages built:
|
The GEOS bump to 3.11 has merged, so the GEOS commit here can be removed! |
GDAL 3.5.2 is out. |
|
@ofborg build openorienteering-mapper I was going to merge this before you pushed the proj change ;) |
@ofborg build qmapshack |
Should I remove it again? |
This fixes the problem but the missing dependencies mentioned in #179406 (comment) are still a problem. |
Does
not help with that? |
No, we'd need to add mapnik's other inputs as well. |
Hmm, and we're still ignoring the tests segfaulting on aarch64-linux Appears to happen @
or, without gdb getting in the way:
|
The actual (optional) dependency is http://www.kealib.org/.
@ofborg build gdal Just checking if my aarch64 machine is alone in getting the segfault. |
Looks like I might be alone and perhaps we should ignore that. Still, makes me a little suspicious. |
Should we just merge and see what happens? We can always revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we'll have to sort out anything remaining in ZHF
either this or #200930 needs to be reverted/fixed, because currently it breaks eval with: edit: this does a lot more stuff, didn't really check the diff before commenting. so maybe just revert 8a236e2 |
"XMLPARSER=libxml2" | ||
]; | ||
|
||
disabled = isPyPy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we place disabled near the top.
|
||
nativeBuildInputs = [ autoreconfHook pkg-config unzip ]; | ||
cmakeFlags = [ | ||
"-DGDAL_USE_INTERNAL_LIBS=OFF" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to disable internal libs? To avoid vendoring? Could this be the reason LERC compression is currently unavailable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid vendoring?
This. It's hard enough to stay on top of all the libs that need security updates in nixpkgs without libraries hiding their own versions all over the place (which they frequently neglect for years)
Description of changes
https://github.com/OSGeo/gdal/blob/v3.5.1/NEWS.md
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes