todoman: disable failing test and unmark broken for darwin #176956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was failing to build on hydra: https://hydra.nixos.org/job/nixpkgs/trunk/todoman.x86_64-darwin. Not sure about aarch64-darwin.
Consider disabling the failing test :) |
ofborg
bot
added
10.rebuild-darwin: 0
|
The tests do take a while to run when I build it locally. I'll take a look at how to disable -- out of curiosity, do you prefer that over extending the timeout because of resource contention on hydra? |
johnjameswhitman
commented
Jun 9, 2022
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
|
Make sure to squash and observe the contributing guidelines regarding commit messages. Something like this |
|
@ofborg build todoman |
|
@ofborg build todoman |
johnjameswhitman
changed the title
ofborg
bot
added
10.rebuild-linux: 0
Mindavi
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The other day I updated my unstable channel and tried switching home-manager to a new generation on my x86 Macbook, but it failed. I tracked it down to
todoman, which was disabled for darwin in37c633fbut seems to build fine for me. I also noticed #173671 (zero-hydra-failures PR) that mentions disabling some packages that were broken on hydra (the PR mentionstodoman, but didn't actually disable it).Things done
37c633fwas addressing it failing on M1 specifically (cc @Mindavi)?sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes