wasmtime: 0.36.0 -> 0.37.0 #173870
wasmtime: 0.36.0 -> 0.37.0 #173870
Conversation
|
@GrahamcOfBorg build wasmtime |
Artturin
added
the
12.approvals: 1
ereslibre
force-pushed
the
bump-wasmtime-0-37
branch
2 times, most recently
from
6105156 to
4fd3b59
Compare
Re-enable darwin platform.
ereslibre
force-pushed
the
bump-wasmtime-0-37
branch
from
4fd3b59 to
dc34b6e
Compare
|
|
||
| # This environment variable is required so that when wasmtime tries | ||
| # to run tests by using the rusty_v8 crate, it does not try to | ||
| # download a static v8 build from the Internet, what would break | ||
| # build hermetism. | ||
| RUSTY_V8_ARCHIVE = "${v8}/lib/libv8.a"; | ||
| RUSTY_V8_ARCHIVE = lib.optionalString stdenv.isLinux "${v8}/lib/libv8.a"; |
There was a problem hiding this comment.
Force pushed to replace lib.optionals with lib.optionalString.
|
The ci is happy, and I can't see anything to change. |
|
@ereslibre ,looks like wasmtime was removed on Darwin again, in: #173671. I wonder why… |
|
@nomeata I will have a look at it; can see that hydra reports a failure on I will try to reproduce what hydra is reporting and mark the package as broken or try to fix the build... |
|
This is probably an issue with the runtime trying to use certain CPU capabilities, errors in the log https://hydra.nixos.org/build/186536905/nixlog/1: I will check later today and disable tests for x86_64-darwin with a comment on why tests are disabled. It's not an optimal solution because we lose that feedback on that platform, but the failure is very tied to the execution environment on x86_64-darwin on the hydra infrastructure. |
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes