awless: avoid building on aarch64-linux #173792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @NixOS/nixos-release-managers for review. |
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
It's so old it's using still using dep so there is no go.mod or go.sum I really think unless you or someone else takes up maintainership of awless this should be dropped. |
| @@ -16,7 +16,7 @@ buildGoPackage rec { | |||
| meta = with lib; { | |||
| homepage = "https://github.com/wallix/awless/"; | |||
| description = "A Mighty CLI for AWS"; | |||
| platforms = with platforms; linux ++ darwin; | |||
| platforms = with platforms; [ "i686-linux" "x86_64-linux" ]++ darwin; | |||
There was a problem hiding this comment.
Please use meta.broken instead.
There was a problem hiding this comment.
Good point -- this was suggested in the larger #173671 PR which marks various packages as broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Disables build of Awless on
aarch64-linux, leaving it enabled for other platforms where it currently builds in 21.11 and master. The upstream project has not updated since 2018 and needs to update its version of x/sys/unix to build onaarch64-linux.We could probably patch its
go.modandgo.sum, but since I do not actively useaarch64-linux, I cannot assume it is backward compatible. (Especially sincex/sys/unixdoes not guarantee backward compatibility.)Relevant discussions and issues:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes