Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-tidy: fix cross-compilation #173736

Merged
merged 1 commit into from
May 22, 2022
Merged

html-tidy: fix cross-compilation #173736

merged 1 commit into from
May 22, 2022

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented May 20, 2022

Description of changes

Fix cross-compilation, upstream PR htacg/tidy-html5#1036.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo May 20, 2022 09:36
@Mindavi Mindavi added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 21, 2022
@Mindavi
Copy link
Contributor

Mindavi commented May 22, 2022

Thanks, that makes more sense to me :)

@Mindavi Mindavi merged commit 4ae5d09 into NixOS:master May 22, 2022
@sikmir sikmir deleted the html-tidy branch May 22, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants