-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde/frameworks: 5.93 -> 5.94 #173266
kde/frameworks: 5.93 -> 5.94 #173266
Conversation
Fixes build on recent compiler and qt versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,9 +1,25 @@ | |||
{ mkDerivation, lib, extra-cmake-modules, python3 }: | |||
{ mkDerivation, python3, qtbase }: | |||
|
|||
mkDerivation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be happier if we used buildPythonApplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, but not sure how that'd pan out with kde's custom mkDerivation
(which merges these attributes with srcs.nix
and versions). Would you have a suggestion on how to integrate buildPythonApplication
with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the trouble worth it? Not like we build several python libraries/applications for all supported python environments/versions, the build is just a couple of setup.py
commands, only enough to satisfy this marginally required dependency. Also, I tried it a little, and my Nix knowledge may not be enough, as it may involve passing the whole attrset of pythonPackages as parameters of the derivation, as is done with the libsForQt5
set, but I'm not sure about the safe way to do this with both in the same call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternately, we could just drop this package. It's never been used in Nixpkgs. I'm not even sure it has ever been buildable before.
Co-authored-by: Sandro <[email protected]>
Description of changes
Bump KDE Frameworks to 5.94, released in 13 May 2022
libsForQt5.plasmaMobileGear: 21.08 -> 22.04 #153329#173264
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notescc @NixOS/qt-kde